search

OpenAgricultureFoundation / openag-device-software

Software for running controlled grow environments on Linux / OSX machines and embedded linux devices such as Beaglebones and Raspberry Pis.
GNU General Public License v3.0
192 stars 50 forks source link

Move bash script logic used in managers and utilities into python functions #166

Closed jakerye closed 5 years ago

jakerye commented 5 years ago

Wherever is reasonable, move logic from bash scripts into python so we don't have to call bash scripts from python.

This will make the logic cleaner / more robust (e.g. able to catch exceptions and have code in 2 places)

rbaynes commented 5 years ago

Good idea. But for some things we still need to start a script to manually do things:

I think that is all I ever use manually. Oh, and we need scripts for the stuff we call from upgrade: pip, collectstatic, etc.

Thanks, Rob Baynes pronouns: he / him / his

On Fri, Oct 26, 2018 at 10:55 AM Jake Rye notifications@github.com wrote:

This will make the logic cleaner / more robust (e.g. able to catch exceptions and have code in 2 places)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/OpenAgInitiative/openag-device-software/issues/166, or mute the thread https://github.com/notifications/unsubscribe-auth/AK6m7ybFFN_ABKF0LGwc6Ad1cd5a6a9Gks5uoyJLgaJpZM4X8ZsS .

jakerye commented 5 years ago

Most of this has been accomplished in the latest installation process refactor