OpenAgricultureFoundation / openag-device-software

Software for running controlled grow environments on Linux / OSX machines and embedded linux devices such as Beaglebones and Raspberry Pis.
GNU General Public License v3.0
193 stars 50 forks source link

refactor environmental state storage method #181

Closed jakerye closed 5 years ago

jakerye commented 5 years ago

Current code served its purpose to get software off the ground but it is time for a refactor.

Considerations

  1. code is difficult to understand
  2. saving entire state every 10 minutes is not memory efficient -- just save deltas -- can generate timeseries data in view function for charts
  3. abstraction to average all sensor variables of same type is overly simplistic -- should be more explicit about location and sensor type

Expansion on point 3

jakerye commented 5 years ago
jakerye commented 5 years ago
jakerye commented 5 years ago

exploring method in cultivation-zone branch

jakerye commented 5 years ago

this is workable for now...until more pressing use case comes along the current solution is fine