search

OpenAgricultureFoundation / openag_python

**DEPRECATED** python code - it now lives in openag_brain/.../openag_lib
GNU General Public License v3.0
20 stars 12 forks source link

Default value for --api_url is missing #5

Closed yaromins closed 8 years ago

yaromins commented 8 years ago

As a follow up to this thread:

If there is no -A is given to main script of openag_brains, then, in turn, no --api_url param is passed to openag db init and no default value set in init.py and couchdb proxy is not setup.

Is there a special reason for such this or I can create a PR with adding default value to @click.option("--api_url", default="http://localhost:5000") ?

LeonChambers commented 8 years ago

This default should be set in openag_brain, not openag_python. openag_python doesn't assume that you're using the ROS stack, so it can't assume that there is an API to proxy at all.

yaromins commented 8 years ago

Ok, makes sense. Here we go https://github.com/OpenAgInitiative/openag_brain/pull/51