OpenAnnePro / AnnePro2-Shine

Custom LED Matrix Firmware for Open Anne Pro 2 QMK Port
GNU General Public License v2.0
100 stars 51 forks source link

Fix the foreground by avoiding animation when foreground is set #32

Closed thomazmoura closed 3 years ago

thomazmoura commented 3 years ago

The changes to enable dynamic lighting broke the foreground color feature. The way I managed to get both working was to skip the animation method altogether when the is_foregroundColor_set is true (that's how it was implemented before the changes for the dynamic lighting, by the way).

There is still a bug with both the foreground color and new reactive fade profile - if you let the profile initial animation end while still holding a layer button, it kind of disables lighting until you change the profile again or enable and disable the leds. But with this fix at least it will work as expected if you release the layer button before the initial animation ends.

Codetector1374 commented 3 years ago

Related to #33