search

OpenAnnePro / AnnePro2-Shine

Custom LED Matrix Firmware for Open Anne Pro 2 QMK Port
GNU General Public License v2.0
100 stars 51 forks source link

Refactor + stupid animation. #49

Closed blaa closed 3 years ago

blaa commented 3 years ago

I did this changes a while back but run out of time shortly afterwards. This should be a simple refactor of a too big file into few smaller ones to simplify navigation. I was trying to build on it with HSV correct led dimming, but it's probably better to split things into smaller PRs. Pessimistically this will linger until I finish the HSV.

I've added additional commit with a reactive profile I wrote. If you don't want it (bloat?) I can remove this commit from the PR. IMHO there could be any number of profiles in the repo, but probably with #defines and compile-time enabled - it's even not that practical to cycle through all available profiles. They should be split into multiple files probalby too.

Codetector1374 commented 3 years ago

We should add profile defines eventually. Bloat is not a immediate concern as AnnePro has this dedicated LED controller so binary size is not too worrying.