Closed zv0n closed 2 years ago
Code change generally looks good to me. Please run clang-format before submit. I think there are some different line endings that is triggering the style check to fail rn.
I currently do not have a board with me, but please make sure you test the changes and it does not regress any existing features (form inspection it shouldn't but always good to be sure)
Thanks for your work 😉
I've formatted the code and rebased it, so it's still a single commit.
I've been using this version of shine for a day or two and all seems fine, but I haven't done any big testing. If you have a list of tests you want me to run I'll gladly test them, but as of now all I can think of is "Let QMK run an animation and then set a mask on caps lock, see if it works" :D
I've added commands to manually control ledColors. I think this can be very useful for the upstream QMK firmware's RGB controls. Currently they rely on setting color through mask, this works but doesn't allow usage of mask for what it's actually meant to be used for (e.g. indication of layer/caps lock/...). With this added functionality the firmware can control colors directly and users can use mask as intended.