OpenAnnePro / qmk_firmware

This has since been merged back to mainline QMK. Please use qmk/qmk_firmware
https://qmk.fm
GNU General Public License v2.0
195 stars 64 forks source link

Include logic to send solid colors as foreground to shine and add sample profiles #14

Closed thomazmoura closed 3 years ago

thomazmoura commented 3 years ago

Include the logic to send a solid color from qmk to shine. Include 2 new profiles based on default to show use cases with the new logic for newcomers and my personal profile as a sample of a more advanced scenario.

Description

Include the logic to send a solid color from qmk to shine. That solid color will act as a foreground (will override the current profile) until reset (witch will reactivate the current profile). This functionality depends on changes made for shine as well.

Include 3 new profiles:

Types of Changes

Issues Fixed or Closed by This PR

Checklist

Codetector1374 commented 3 years ago

I understand you have your profile setup as an advanced example, however if possible I think it would be nice if you can "include" the main makefile and then override some configs. (I think it should be possible)

thomazmoura commented 3 years ago

Sorry, I'm not sure I understood that.

You're suggesting I make further changes to my personal profile to use it as a sample?

So far all the changes I had to make that were kind of "internal" I managed to make by adding further files to my own profile such as the thomazmoura/config.h . I've done so to be able to set them without changing the other profiles or the "core" of the QMK port. Is there another way to do it which would be more appropriate?

thomazmoura commented 3 years ago

Sorry, I guess I understand it now. I've referenced rules.mk to enable the tap dance feature. I'll try to enable it without the rules.mk layer (setting it on the config.h) and see if it works.

Codetector1374 commented 3 years ago

Sorry, I guess I understand it now. I've referenced rules.mk to enable the tap dance feature. I'll try to enable it without the rules.mk layer (setting it on the config.h) and see if it works.

That is one option. I was originally suggest that you can have a rules.mk but all you have in there is just

include ../../rules.mk
FEATURE=TRUE etc...

so if we make changes to the SRC list etc we only have to change it at one place