CTD: transfering engineers

OpenApoc / OpenApoc

Opensource rebuild of the XCOM Apocalypse Engine that requires the original files to run.

http://openapoc.org

GNU General Public License v3.0

508 stars 99 forks source link

CTD: transfering engineers #505

Open BeornTB opened 5 years ago

BeornTB commented 5 years ago

All transfering personel was unassigned to begin with.

345 CTD engineer transfer.zip

Soldiers were transfered without problems earlier on, so it seems to be about scientists. Possibly related to #482

BeornTB commented 5 years ago

Selling/buying from one to the other works but they stay assigned and their proficiency keeps counting.

https://i.imgur.com/N6e2h6t.png

Jarskih commented 5 years ago

Did you start new game? The fix to scientist bug only works for the new saves.

BeornTB commented 5 years ago

Yes, brand new game with the OpenApoc-x64-v0.1-345-gea6033fa build, which I took as the "stable" 345 master build.

Jarskih commented 5 years ago

Ok I will take a look.

FilmBoy84 commented 5 years ago

Another example of this bug

Savegame Attached (May need old weapons mod from the discord modding channel) save_Medium Test 06-02-19 1.zip

FilmBoy84 commented 5 years ago

Please see also issue #532 which is a duplicate

Dago73 commented 5 years ago

saves.zip Here my last 3 saves to debug

Atrosha commented 5 years ago

https://github.com/OpenApoc/OpenApoc/issues/532#issue-421676938

gdb log and stack trace for 1 of #532 issue

532_1_gdb_log_n_stack_trace.txt

Atrosha commented 5 years ago

Also there is no crash on case 2. It's just shows MessageDialog with "Alien Containment exeeded"

FilmBoy84 commented 5 years ago

Ah, the alien containment issue is good old #369 i'll reference this there too Thanks for the report <3

FilmBoy84 commented 5 years ago

See also #370

Atrosha commented 5 years ago

stack trace for case 3

532_3_gdb_log_n_stack_trace.txt

Dago73 commented 5 years ago

Here a screen shot grafik Left is Biochemie with 9 scientist. Every time i klick on the Lab, i get the message you can see.

Atrosha commented 5 years ago

After a lot of smth like that message dialogs game crashes.

JonnyH commented 5 years ago

I think what's happening here is when transferring or selling scientists it's not disassociating them from any lab they're currently working in, so the lab holds a reference to that agent.

And nearly always you get a missing ID error, it'll crash directly afterwards - as it'll return a null object - so unless the code then doesn't use the object at all (in which case why is it bothering to look it up?) it'll deference that null pointer.

FilmBoy84 commented 5 years ago

@JonnyH another instance of this bug Here's the crash dump Created when trying to transfer a skill 100 engineer from Base 1 to Base 2

save_Expanded Weapons Test 1.zip

OpenApoc.exe.10340.dmp.zip

To run the savegame, you will need V3 of the weapons mod XCOM UFO TFTD Weapons Mod - Voiddweller and FilmBoy84 v3.zip

emptyVoid commented 4 years ago

Cannot reproduce -- should be fixed by #720.