OpenArchive / Save-app-android-old

This is the Save app for Android
https://open-archive.org
GNU General Public License v3.0
94 stars 25 forks source link

Settings page going blank after clicking the back button #462

Closed vanichitkara closed 11 months ago

vanichitkara commented 1 year ago

Describe the bug The settings page goes blank when clicking on the back button when on the main settings page

To Reproduce Steps to reproduce the behavior:

  1. Go to the settings page
  2. Click any tab
  3. Click the back button to go back to the main settings page
  4. Click the back button again
  5. A blank screen appears
  6. Pressing the back button again at this stage closes the app

Expected behavior Pressing the back button should ideally redirect to the My Media page

Video with the bug reproduced https://github.com/OpenArchive/Save-app-android/assets/64951124/bdf7f3b5-13c1-4bd0-8779-3f490636bb22

Environment (please complete the following information):

Additional context The expected behaviour can change depending on how we design the flow of the app, but ideally pressing the back button should take the user to My Media page where they can add folders rather than showing them a blank screen or exiting the app after pressing the back button.

tladesignz commented 1 year ago

@purvi-ranawat, the fix will be contained in the upcoming version 0.3.0-alpha6 build 20535 and later!

purvi-ranawat commented 1 year ago

@tladesignz : Now, when I go to Settings -> any settings options and then click on back, instead of going to Main Settings screen, it takes me directly to My Media screen

Below is the video :

https://github.com/OpenArchive/Save-app-android/assets/8190141/79eacacc-470e-485b-b503-40bbbaed2898

Details :

OS : Android 11, Android 13 Device : Samsung Galaxy A70, Samsung Galaxy A13 App Version : 0.3.0-alpha6

uniqx commented 1 year ago

fixed by https://github.com/OpenArchive/Save-app-android/commit/9186aabbd61e81bc6a582be5ab1810356c5b314d will be released with 0.3.0-alpha9

foundscapes commented 11 months ago

@purvi-ranawat please test, we can't reproduce this problem in beta1, so hope to close. thanks!

purvi-ranawat commented 11 months ago

This is working fine.

Environment : OS : Android11, Android 13 Device : Samsung Galaxy A13, Samsung Galaxy A70 Build Version : 0.3.0-beta1