Open tladesignz opened 1 year ago
Heads up for testing: I've observed a peculiarity when implementing the upload progress spinner. The actual upload is very quick (1 to 3 seconds when I tested it). Before the upload happens there seems to be some sort of preparation which takes 10 to 20. During this preparation the indicator will still be in an indeterminate ("spinning") state. Also after the upload when the indicator is at 100% there seems to be some sort of post processing. In this state, the indicator keeps displaying 100% (full circle ~10 seconds for me) before the UI gets the signal that the upload is completed.
Are we able to include the % in the progress circle as it used to be? @uniqx
@uniqx does this issue prevent you from ensuring there is a % inside the circle to show accurate progress? If so, what is blocking you from implementing the % progress indicator and can we help? ty!
There's no block to displaying progress percentage number there. (I wasn't aware that's a requirement. I've only implemented the determinate spinner feature as described in this issue.) I'll add a percentage number display.
will look like this in the next release:
@uniqx : Is this implemented?
will be available in 0.3.1-alpha2
Is this ready for QA? If so, please assign to Purvi and set project status to "awaiting QA". Thanks!
@purvi-ranawat please test!
@foundscapes : Now I am able to see the %age of media uploaded inside the circle. This is working fine
Below are the screenshots :
Environment :
OS : Android 14 Device : Oneplus Nord 3 CE Lite, Samsung Galaxy A13 Build Version : 0.3.1-alpha2
I don't think the percentage should be black. I just recently had this worked out for iOS. Please color it green like the spinner, @uniqx! Thanks
Hi @vanichitkara, I have also changed the progress text color in an internal test build (version 0.3.2)
Thank you @ryjen fixed in 0.3.2, tested on moto g pure, android 10
The loading spinners are not visible in Android 14 for the 0.3.2 version. Only the %age is visible. Also, when I see the uploads in the edit uploaded media queue, the %age font colour is white instead of teal.
Teal % in teal circle working for me BUT it's white% in teal circle in the edit scene phone: google pixel 3a OS: Android 12 Save version: 0.4.0 Server: gDrive
@vanichitkara can you test on 0.4.0 to see if it's working now? ty!
@foundscapes I'm seeing the white % but no teal circle in the edit scene. I checked this on both IA and Dropbox servers. The teal % in the teal circle is working fine on the main page. Phone: OnePlus 11R OS: Android 14 Save version: 0.4.0 Server: IA and Dropbox
@foundscapes/ @upulw2020 : %age in the teal circle is shown in black on Edit Screen.
I have tested this on 0.7.2 version of Save
Below is the screenshot :
Simple colour change on upload percentage required on edit screen. Minor usability issue. Moving this ticket to low priority as it doesn't affect functionality.
Android has only onboard resources for circular indeterminate spinners or linear determinate progress bars.
Please rework the
ProgressBar
elements in allrv_media*.xml
layout files to show a circular determinate spinner.This tutorial might help: https://www.geeksforgeeks.org/how-to-create-circular-determinate-progressbar-in-android/
When done, remove all appearances of numeric progress indication in these layout files and clean up the
MediaViewHolder
.Thank you!