OpenArchive / Save-app-android-old

This is the Save app for Android
https://open-archive.org
GNU General Public License v3.0
94 stars 26 forks source link

Flagged content no longer is routed to separate subfolder #519

Closed ceylana closed 8 months ago

ceylana commented 8 months ago

When I flag media as significant when editing the metadata (select little flag icon) it is no longer routed to a separate folder once uploaded. I tested this on both Nextcloud and Dropbox and the issue persisted

To Reproduce Steps to reproduce the behavior: 1.Add media

  1. Edit media and select the flag
  2. Upload media to selected folder/server
  3. Check server for upload and see that flagged media isn't in flagged/separate folder

Expected behavior Media that is flagged should go into a separate folder once uploaded.

Screenshots

json showing flag is true

You can see in the json file with data from the image that flag = true but it isn't going into that separate folder

Below you can see that image isn't in separate folder image not in separate folder

Environment (please complete the following information):

Additional context was also not working on beta 5

foundscapes commented 8 months ago

Good catch @ceylana! This happened to me as well

OS version: Android 12
Device: Google Pixel 3a
App Version 0.3.0 beta 6
tladesignz commented 8 months ago

Investigated the code yesterday. Not sure the Android version ever did this. That part of the Android app is still a mess. I already started refactoring this, but won't be able to finish until next week.

foundscapes commented 8 months ago

@tladesignz the flagging feature was working on Android during one of our recent trainings.

foundscapes commented 8 months ago

@vanichitkara please test after next week, ty!

tladesignz commented 8 months ago

@tladesignz the flagging feature was working on Android during one of our recent trainings.

Well, if that was so, than I destroyed it accidentally, because it must have been an ugly, undocumented hack.

I reworked this mess into something sensible.

@purvi-ranawat, this will be contained in version 0.3.0-beta7 due for release soon.

foundscapes commented 8 months ago

This is working fine for OA Core so I'm closing, ty all!