OpenArchive / Save-app-android-old

This is the Save app for Android
https://open-archive.org
GNU General Public License v3.0
94 stars 26 forks source link

Full sentence not showing up in the modal before uploading media #527

Open vanichitkara opened 8 months ago

vanichitkara commented 8 months ago

Describe the bug When trying to upload media, the modal before the upload starts has the text cut and doesn't show the full sentence. Also, the text size looks big on the screen; the text could be shorter.

To Reproduce Steps to reproduce the behaviour:

  1. Go to a folder and select some media to upload
  2. The screen will appear

Expected behavior Expected behaviour is that the sentence should not be cut off and should be fully visible.

Screenshots Screenshot_2023-11-04-17-43-34-58_0ee13e842c552dd3714f8967301299aa

Environment OS version: Android v13.0 Device: OnePlus 11R 5G App Version 0.3.0-beta7

Additional context Add any other context about the problem here.

foundscapes commented 7 months ago

Not happening for two of us on OS 11 and 12 - @purvi-ranawat please test on OS 13 ty!

purvi-ranawat commented 7 months ago

@foundscapes : The issue exists for me also on Android 13 OS

Below is the screenshot :

full sentence not shown

Environment : OS ; Android 13 Device : Samsung Galaxy S23 FE Build version : 0.3.0-beta8

foundscapes commented 7 months ago

ty @purvi-ranawat~ @uniqx this seems like it's an android OS 13 issue, is there anything you can do to ensure the language shows up on that platform/across all platforms? ty!

uniqx commented 7 months ago

After a little debugging I think this issue is dependent on the screen size, and font-size settings. I've implemented a fix where I change maxLines from Androids default value (2) to 99.

659771b

ceylana commented 7 months ago

@purvi-ranawat and @vanichitkara can you test to see if this is resolved please?

purvi-ranawat commented 7 months ago

@ceylana / @foundscapes : I have tested the same on Android 13 and it is working fine now.

Environment : OS : Android 13 Device : Samsung Galaxy A13 Build Version : 0.3.0

vanichitkara commented 4 months ago

@foundscapes I'm still facing this issue Environment OS version: Android v13.0 Device: OnePlus 11R 5G App Version 0.3.1-alpha2

ryjen commented 4 months ago

That does not look like a proper title in the screen shot anyway. Can we use a more concise title (uploads) and put that string into the description below it? @uniqx