OpenArchive / Save-app-android-old

This is the Save app for Android
https://open-archive.org
GNU General Public License v3.0
94 stars 26 forks source link

App crashing continuously on Android 14 #528

Closed losalim closed 8 months ago

losalim commented 8 months ago

Describe the bug One of our DAC managers is on Android 14 and the app won't stop crashing from him upon download/uninstall/download.

Environment (please complete the following information):

Additional context App in Spanish

losalim commented 8 months ago

David is using a Pixel 6a phone.

Adding screenshot

signal-2023-11-14-161933

uniqx commented 8 months ago

fixed by 53248a3

uniqx commented 8 months ago

Starting on Android 14 foreground services require to declare additional permissions. So that's the fix I've provided. As I've just learned, Google Play has additional policy restrictions for these new permissions. They require to publishers to provide a screen capture demonstrating when the foreground service is in use. I did attempts recording such a screen capture, but I couldn't get the foreground service icon to show up. So I'll have to do more debugging and figure out what the foreground service code actually does. I have to check if it's obsolete, or needs fixing and follow up accordingly.

uniqx commented 8 months ago

after a little more debugging and some minor refactoring I could the foreground service to show up. That allowed me to create the video Play Console asked for submitting a new release with foreground service permission.

foundscapes commented 8 months ago

@vanichitkara please test, ty!

vanichitkara commented 8 months ago

@foundscapes I'm on Android 13 so I won't be able to test the issue on Android 14

foundscapes commented 8 months ago

@vanichitkara ok no worries, ty!

foundscapes commented 8 months ago

@purvi-ranawat please test on Android 14 ty!