OpenArchive / Save-app-android-old

This is the Save app for Android
https://open-archive.org
GNU General Public License v3.0
93 stars 26 forks source link

Biometrics setup missing #568

Closed ryjen closed 4 months ago

ryjen commented 4 months ago

Describe the bug When toggling biometrics on a device without any biometrics setup, the UX is broken.

Preconditions Remove biometrics on the device Remove the application from the device

To Reproduce Steps to reproduce the behavior:

  1. Install the application and setup a backend
  2. Goto preferences and turn on proof mode and biometrics
  3. See blank screen, restarts and no Biometrics unlock

Expected behavior The user is taken outside of the app and prompted to set up biometrics for the first time. Then returns with the setting enabled.

Environment

Additional context See https://developer.android.com/training/sign-in/biometric-auth

and using a finger print with ADB (for automation)

adb -e emu finger touch 12341234

ryjen commented 4 months ago

Hi @vanichitkara , this can be tested with an internal testing build (version 0.3.2)

preconditions A phone that supports biometric fingerprints

The process is as follows:

  1. remove all PINs and Fingerprints from settings on the device
  2. go to settings on the Save app
  3. go to ProofMode
  4. enable biometrics

expected

The app will prompt to setup a PIN and Fingerprint (if available)

losalim commented 4 months ago

Works for me! Tested on MotoG Pure, Android 10

losalim commented 4 months ago

re-opening as I'm not on the newest release. will QA again when i am!

losalim commented 4 months ago

updated to newest version and working well.

vanichitkara commented 4 months ago

Though I'm late, but yes, it works for me as well on Android 14, app version 0.3.2