OpenArchive / Save-app-ios

Secure Mobile Media Preservation
https://open-archive.org/
GNU General Public License v3.0
10 stars 3 forks source link

[Suggesstion] : Message / Notification should be displayed when we have selected upload only when you are connected to Wifi option #159

Closed purvi-ranawat closed 7 months ago

purvi-ranawat commented 5 years ago

When we have selected the option "Upload only when wifi is connected" and user have not connected to wifi and try to upload the media, a notification / message should be displayed stating to connect to Wi-fi .

Currently, if we have selected the option "Upload only when wifi is connected' and not connected to wifi and try to upload the media, no notification is displayed and the media remains in "uploading" mode. This confuses the user as the status shows "uploading"

foundscapes commented 8 months ago

@purvi-ranawat is this still an issue?

purvi-ranawat commented 8 months ago

@foundscapes : The issue still exists

Tested on below environment :

OS : IOS 17.2 Device : Iphone XR Build version : 3.1.0, build 93

tladesignz commented 8 months ago

Ok. So I tackled this from two sides: Similar like the warning when there's no Orbot, although the user said there should, there's now also a warning when there's no Wi-Fi, although the user said there should.

Additionally, when there's no Wi-Fi or no Orbot, the header will now show "Waiting…" instead of "Uploading…".

Will be available in build 95.

Please advise if and how you want to have this improved further.

purvi-ranawat commented 7 months ago

The message is displaying ok. But in the message, the word "again" is trimmed from the bottom.

Below is the screenshot :

Image

Environment details :

OS : IOS 17.2 Device : Iphone XR Build Version : 3.1.1, build 101

tladesignz commented 7 months ago

Yeah, this is what you get when you want to use another font so much. It's possible, but you get side-effects.

A fix will be contained in build 102.

purvi-ranawat commented 7 months ago

This is working fine.

Below is the screenshot :

Image

Environment Details :

OS : IOS 17.2 Device : Iphone XR Build Version : 3.1.1, build 103