search

OpenArchive / Save-app-ios

Secure Mobile Media Preservation
https://open-archive.org/
GNU General Public License v3.0
10 stars 3 forks source link

Sharing image from Signal to Save crashes app - does not populate in Save #187

Closed foundscapes closed 2 years ago

foundscapes commented 2 years ago

Describe the bug When trying to share an image from the Signal App to Save through the native iOS function, two problems arose.

  1. If you click through after "import" and don't click on the "you have 1 items ready to upload to *project folder" popup, either the Save app crashes when trying to open it the first time, or it opens the second time, but the image is not there or in the queue
  2. If you click through after "import" and do click on the "you have 1 items ready to upload to *project folder" popup, it takes you to a blank screen in Save where image should be but isn't

To Reproduce Steps to reproduce the behavior:

Install Save
Provide valid creds for NextCloud Server
Create new project
Select a single file from Signal, tap/hold and choose "share" option
Share to Save app

Expected behavior The file is added to your upload queue, is editable, and can be uploaded

Environment (please complete the following information):

OS version: iOS 15.4.1
Device: iPhone 12 mini
App Version: ??

Additional context No error is presented to the user. The Save app opens with a black space.

foundscapes commented 2 years ago

This happens with the share feature from every app I've tried so far - twitter, photos, signal

tladesignz commented 2 years ago

Fixes will be contained in the next TestFlight. Please re-test then to make sure I caught every circumstance!

purvi-ranawat commented 2 years ago

Let me know once the new build is updated so that I can retest the issues

On Wed, Apr 27, 2022 at 5:58 PM Benjamin Erhart @.***> wrote:

Fixes will be contained in the next TestFlight. Please re-test then to make sure I caught every circumstance!

— Reply to this email directly, view it on GitHub https://github.com/OpenArchive/Save-app-ios/issues/187#issuecomment-1110941333, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB6PRPK6AJ5UJEQV4TMWGS3VHEXHXANCNFSM5UJUADWA . You are receiving this because you were assigned.Message ID: @.***>

-- Regards Purvi

tladesignz commented 2 years ago

Let me know once the new build is updated so that I can retest the issues

Available! If you use the TestFlight app, it should notify you automatically.

foundscapes commented 2 years ago

Still happening when trying to share files to Save from other apps on test flight v. 2.7.0

foundscapes commented 2 years ago

I tested and the same issue on the new build and it had the same behavior, got an error message and also a msg saying it was in queue (see screenshot) IMG_0587

tladesignz commented 2 years ago

Aha. You found more issues.

  1. I fixed the notification. Will not be shown anymore, if all files to import had errors. If some files had errors, the number of files which actually were imported is shown. (Yes, you can share multiple files at once.)
  2. Signal (and potentially other apps) share images not as file URLs to read from, but as UIImage objects. (D'oh!) I added support for that, too.

I tried videos, PDFs and audio with Signal, too, but these types were properly shared as file URLs, as expected.

If you find more app/content type combinations which don't work, please let me know, then I'll try my best to reproduce and add support.

Sorry for this. Unfortunately our share extension has 2 problems:

  1. The Interface from Apple is not unambiguously defined, so every app seems to use it in a slightly different way.
  2. The database abstraction framework we use has design issues with 2 processes accessing it simultaneously. That was an error of judgement from my side. Sorry for that. Unfortunately, too late to use something different. (And other options have other problems, too...)
purvi-ranawat commented 2 years ago

@tladesignz / @foundscapes : I have tried the above mentioned scenarios through signal, twitter and photos app and it was uploaded successfully. I didn't got the blank screen or the app didn't crashed.

But I have noticed one thing. If after installing the app , I havent accessed the app for some time and may be access the phone after an hour or so and then try uploading, the app crashes (I will try to reproduce the error and upload the video)

tladesignz commented 2 years ago

@tladesignz / @foundscapes : I have tried the above mentioned scenarios through signal, twitter and photos app and it was uploaded successfully. I didn't got the blank screen or the app didn't crashed.

Thank you, @purvi-ranawat! Glad to hear, that I finally start to nail this down.

As said, please, you all, continue testing with various apps and types of content, so we're able to catch all corner cases.

But I have noticed one thing. If after installing the app , I havent accessed the app for some time and may be access the phone after an hour or so and then try uploading, the app crashes (I will try to reproduce the error and upload the video)

Interesting. When you do that, please note down the type of server and the settings you're using, as the different types vary widely in implementation.

purvi-ranawat commented 2 years ago

@tladesignz : Sure. I will try to reproduce the error and let you know the type of server and the settings if encountered the error