search

OpenArchive / Save-app-ios

Secure Mobile Media Preservation
https://open-archive.org/
GNU General Public License v3.0
10 stars 3 forks source link

Size of same upload varies #199

Closed johnhess closed 2 years ago

johnhess commented 2 years ago

While a video is (waiting to be) uploaded, the file size changes. In the uploads pane, I see the same file depicted as 49.1MB (the size it will eventually be when uploaded to dropbox) and 47.1MB and 43.4MB. Perhaps during transcoding this is the size transcoded so far?

The video in these screenshots is 49.1MB in dropbox after successful upload and 28.5MB on the phone (presumably before transcoding). In all cases, the file eventually ends up being described in the uploads pane as 49.1MB.

image image

tladesignz commented 2 years ago

Yeah, the file size change is due to the import going on in the background. Having this changing infrequently is a side effect of how it is implemented: The real file size will be read on every access of the Asset.filesize property, in order to give the most accurate value.

As you know with video transcoding, it is unclear what the final size will be, until the transcoding finishes.

@johnhess, do you consider this behaviour confusing? If so, what would be a good remedy?

johnhess commented 2 years ago

I think it's a low severity issue, but it is confusing. If I were a pay-by-the MB customer, and I uploaded a large video, then saw that in my upload list it said "20MB", I might happily go get some coffee. Then I'd come back to find that my app used 800MB of data. Then I would cry.

I agree we can't know the final file size til we have encoding finished.

In lieu of "size so far", how about a string indicating what's happening "Encoding file" or "Processing video" or the like? If I had to pick, I'd say encoding because it is specific. I'm open to other copy if you have something you prefer.

tladesignz commented 2 years ago

Yeah, that makes sense. Now clearer to the user what's going on and why nothing's uploaded, yet.

Will be contained in TestFlight build 61.

purvi-ranawat commented 2 years ago

@tladesignz @johnhess I'm getting Encoding file and then it starts uploading.

purvi-ranawat commented 2 years ago

@tladesignz / @johnhess : Also, when we try to upload the image through sharing (Sharing through any app like photo gallery, Signal, etc), Encoding file is not coming. Instead we directly get the size of the file and the uploaded size. Only when we go to Save app and select media from there, then only Encoding file is coming

johnhess commented 2 years ago

Based on today's discussion, this is working as intended since encoding happens in the share context.