search

OpenArchive / Save-app-ios

Secure Mobile Media Preservation
https://open-archive.org/
GNU General Public License v3.0
10 stars 3 forks source link

Make text size adjustable with iOS accessibility settings #213

Closed huertanix closed 2 years ago

huertanix commented 2 years ago

Per the Apple's HIG guidance (https://developer.apple.com/design/human-interface-guidelines/accessibility/overview/text-size-and-weight/), text sizing should be adjustable via iOS settings, to make it easier for older users and other differently sighted people to use.

tladesignz commented 2 years ago

Great catch, thank you!

Situation much improved with upcoming build (63). Please test with next TestFlight.

Note: Some texts might not appear bigger, due to other constraints. E.g. text needs to fit in a line, so font size is scaled down to fit.

I might have overlooked 1 or 2 items. Happy if you find them.

huertanix commented 2 years ago

Poked around different parts of the app, text sizing seems to work in most places, but there's some rough edges here and there:

cancel_done_text_sizing

In the media upload dialog, "Cancel" has its size adjusted accordingly, but "Done" does not. Also, the time label for video media stays the same size (this might just be an iOS thing that can't be changed though).

connect_your_space_text_wrapping

In the dialog to connect a new space, some text that gets maybe too big gets lost under the metaphorical fold.

media_uploads_line_spacing

In the display for media in a project, the line spacing can use some adjustment according to text size. Also, the project name doesn't get larger with text size settings.

upload_chunking_small_text

Upload chunking option label seems to not grow larger with larger text size settings.

tladesignz commented 2 years ago

In the media upload dialog, "Cancel" has its size adjusted accordingly, but "Done" does not. Also, the time label for video media stays the same size (this might just be an iOS thing that can't be changed though).

sigh Yet another fork of a dependency: https://github.com/tilltue/TLPhotoPicker/pull/341

In the dialog to connect a new space, some text that gets maybe too big gets lost under the metaphorical fold.

Fixed.

Upload chunking option label seems to not grow larger with larger text size settings.

Fixed.

Will try to improve the main scene tomorrow.

Find improvements in upcoming TestFlight build 66.

purvi-ranawat commented 2 years ago

@tladesignz It is working good in most of the places except Select Media screen. Fonts for Recents and Videos do not change.

Tested on version 66.

Image

tladesignz commented 2 years ago

Good catch, @purvi-ranawat, thank you!

Fix will be contained in next TestFlight (build 67).

purvi-ranawat commented 2 years ago

It works fine. Tested build 67.