OpenArchive / Save-app-ios

Secure Mobile Media Preservation
https://open-archive.org/
GNU General Public License v3.0
10 stars 3 forks source link

Confirm sanity re: adding Dropbox Key to repository; Add Key to iOS #228

Closed johnhess closed 1 year ago

johnhess commented 1 year ago

There are 2 sides to the dropbox app credentials.

They are, confusingly, called the "Key" and "Secret". It is my understanding that the key is used only to identify the app, and that since we ship in each APK it is defacto a public identifier, not private information. The user's own credentials are, of course, what's used to upload to their account.

As I understand it, we do not use the "Secret" at all, though IIRC, it is declared in our iOS codebase.

My proposal, so long as you don't think this exposes private information in a damaging way, would be to simply add the Key but NOT the Secret to each application.