OpenArchive / Save-app-ios

Secure Mobile Media Preservation
https://open-archive.org/
GNU General Public License v3.0
10 stars 3 forks source link

Implement new image selection #240

Closed hiromipaw closed 9 months ago

hiromipaw commented 11 months ago

With the new image selection flow images are highlighted when selected (previously only the border would be in green):

Selected Image

Once some images are selected the user can add more from the bottom menu or just upload the added media:

Preview Images

Clicking on an image allows the user to edit info for that media:

Preview Images - Instructions

If the user decide to upload the medias directly a warning is displayed:

Upload - Instructions screen

Media information can be edited for multiple of single files by selecting one or more files: Preview Media

For single media: Single Media Info

For multiple media at once: Multi Media Info

Information is added in a form: Adding Info - Instructions

If back button is pressed a warning is displayed: If pressed back

Figma: https://www.figma.com/file/MngzLdtPsEmvEsUPKsbmE8/Save-App-2.0

tladesignz commented 9 months ago

@purvi-ranawat, this will be contained in version 3.0.0, build 82.

purvi-ranawat commented 9 months ago

@tladesignz :

  1. When we select the image, it is not highligted. Like in previous version, only Green border is displayed.

Image

  1. "Add More" text is not displayed on the Upload screen like given in the requirements for adding more media. Only "+" sign is displayed in the bottom bar to add more media 💯

Image

  1. On the Edit screen after making the changes, when we press the back button, no warning is displayed. As per the requirement, below text should be displayed :

Image

tladesignz commented 9 months ago

@tladesignz :

  1. When we select the image, it is not highligted. Like in previous version, only Green border is displayed.

Yeah. The media picker is a third party library, which we won't meddle with. That would drive up costs for maintaining a fork for no serious gain.

  1. "Add More" text is not displayed on the Upload screen like given in the requirements for adding more media. Only "+" sign is displayed in the bottom bar to add more media 💯

True. The iOS UI element used here isn't capable of displaying buttons with text + icons. The UX of iOS is well thought thru, so this is probably a very deliberate decision. If this is sooo important, we would need to replace the preexisting tools with home-made stuff which I really don't want until somebody finds this so important that they either make me do it anyway, or have a really convincing argument. So, I won't change this until somebody throws an explicit issue about it at me.

  1. On the Edit screen after making the changes, when we press the back button, no warning is displayed. As per the requirement, below text should be displayed :

While implementing on the Android side, we came to the conclusion, that this is a rather stupid UX. Everything is stored, always. The users cannot lose data, so no warning necessary.

Thank you, @purvi-ranawat, for your diligence!