Implement folder settings

OpenArchive / Save-app-ios

Secure Mobile Media Preservation

https://open-archive.org/

GNU General Public License v3.0

10 stars 3 forks source link

Implement folder settings #243

Closed hiromipaw closed 7 months ago

hiromipaw commented 10 months ago

Settings for folders show active and archived folders depending on what the user has:

All types

Active Projects Only

Active Projects Only-1

You can pick name and license type for the full folder or all folders and you can also delete a folder:

Projects-1

Projects

When a folder is deleted a confirmation popup is displayed: Remove Space

Remains to be clarified what should happen when a user changes the license for the whole server (aka. space)?

tladesignz commented 8 months ago

@purvi-ranawat, will be contained in version 3.0.0, build 81 currently uploading.

purvi-ranawat commented 7 months ago

@tladesignz :

As mentioned in the requirement screenshot, the marked text is different and also, the title "Active folders'" is not displayed in the actual :

Requirements :

Actual :

As mentioned in the requirement screenshot, the marked content is different and also , the title " Folder Name" is missing.

Requirements screenshot :

Actual Screenshot :

Delete confirmation pop up is different :

Requirements screenshot :

Actual screenshot :

Environment :

OS : IOS 17.2 Device : Iphone XR Build version : 3.0.0-build 83

tladesignz commented 7 months ago

Thank you, @purvi-ranawat, for your attention to detail, as always!

@tladesignz :

As mentioned in the requirement screenshot, the marked text is different and also, the title "Active folders'" is not displayed in the actual :

I added the title.
I didn't change the text of the CC stuff:
- When doing the Android development, there was some spec change, because text was misleading otherwise in the first item.
- The second item is the same on Android. Won't change to not impact translation again until management comes up with a good reason.

As mentioned in the requirement screenshot, the marked content is different and also , the title " Folder Name" is missing.

I added the title.
Regarding the different labels: See comment above.

Delete confirmation pop up is different :

The text was misleading (we're not deleting a "space" here, but a "folder"). Anyway, I adapted the text to get closer to the design template.

The fixes will be contained in version 3.0,0, build 85.

purvi-ranawat commented 7 months ago

This is working fine now as per the comments above.

Environment :

OS : IOS 17.2 Device : Iphone XR Build Version : 3.0.0. build 85