search

OpenArchive / Save-app-ios

Secure Mobile Media Preservation
https://open-archive.org/
GNU General Public License v3.0
10 stars 3 forks source link

Uploaded numbers formatting change requested : can we round the boxes, make them teal with white or black numbers (depending on light/dark mode) #260

Closed losalim closed 7 months ago

losalim commented 7 months ago

Describe the bug Can we edit the number boxes on the right on the my media screen ? changes would include making the grey boxes rounded and teal, and the characters white or black.

To Reproduce Steps to reproduce the behavior:

  1. Go to my media screen
  2. See error

Expected behavior boxes with number of uploads should be formatted with rounded boxes. Can we make these boxes teal? And have white or black characters depending on light/darkmode?

Screenshots Adding screenshot of ios app right now iosDec4

Smartphone (please complete the following information):

tladesignz commented 7 months ago

boxes with number of uploads should be formatted with rounded boxes.

Interesting. It actually is like that, only not on iOS 17, as I found out, when trying to reproduce.

Obviously, it's a bug in iOS 17. Anyway, I found a fix.

Can we make these boxes teal?

Well, that's definitely not in the design specs. And, TBH, I don't think that would look good - too much teal. That will need a management decision from @foundscapes or @ceylana.

And have white or black characters depending on light/darkmode?

Experimented with that again and checked the design templates. You're right, text color should be the same as that of other text. I picked a too dark gray the first time for the background, that's why I inverted the label color, but only white on that gray actually works good.

So I now experimented with the gray and found one, which actually works with the determined text color.

tladesignz commented 7 months ago

Fix will be contained in version 3.0.1, build 88.

ceylana commented 7 months ago

Let's see how the new colors look in build 88 and then we can make a decision on the teal question. Just want to make sure it is accessible color-wise to those with difficulty seeing.

ceylana commented 7 months ago

@tladesignz confirming that the numbers are now in the rounded grey boxes.

Referenced the designs in figma for the colors to be used for accessibility purposes. For dark mode: please change the grey circle to HEX color # 434343 (number should be white). for light mode: please make sure the grey circle is HEX color #E3E3E4 (number should be black).

thanks!

tladesignz commented 7 months ago

As you wish...

Will be contained in version 3.0.1, build 91.

losalim commented 7 months ago

Tested in build 91. Issue resolved