search

OpenArchive / Save-app-ios

Secure Mobile Media Preservation
https://open-archive.org/
GNU General Public License v3.0
10 stars 3 forks source link

Font in iOS is incorrect #263

Closed losalim closed 6 months ago

losalim commented 7 months ago

Describe the bug Font throughout app should be Montserrat

Smartphone (please complete the following information):

tladesignz commented 7 months ago

Unfortunately, this isn't a just-fix-once-and-be-good issue.

Can you please show me, where it is wrong? I'm afraid I will have to take care of every single item personally.

tladesignz commented 7 months ago

Ahahaha. I played around with this problem. Again. And now, I remember:

It is ridiculously complicated to replace the font everywhere, hence we agreed on only using Montserrat in headings and such. Many of these probably didn't survive the redesign, because I forgot about it.

Anyway, I tried to fulfil your wish, and I probably succeeded mostly.

Go hunt for missing changes. Could be, that we cannot do anything about it without spending horrendous amounts of hours on it, but eventually, you'll find some, which are easy to fix.

That font still looks ugly on iOS, from my point of view. But, well, you're paying, so there you are.

tladesignz commented 7 months ago

Will be contained in version 3.0.1, build 91, which I'll upload in a minute!

purvi-ranawat commented 7 months ago

This is working fine.

Environment : OS : IOS 17.2 Device : Iphone XR Build Version : 3.0.1, build 91

losalim commented 7 months ago

I agree i think this is largely fixed. one issue though is that the first welcome screen that says SAVE down the side now also has that font when i think that page was supposed to be unique

tladesignz commented 7 months ago

I agree i think this is largely fixed. one issue though is that the first welcome screen that says SAVE down the side now also has that font when i think that page was supposed to be unique

That's one of the obstacles, why it makes it difficult to change a font app-wide.

I fixed it for that special case. Will be contained in build 92.

Let me know, if you find more of these places, @losalim.

losalim commented 6 months ago

Tested on build 93. All fixed thank you!