search

OpenArchive / Save-app-ios

Secure Mobile Media Preservation
https://open-archive.org/
GNU General Public License v3.0
10 stars 3 forks source link

Internet archive : Entering random characters in secret keys for internet archive does not give any error message #270

Closed purvi-ranawat closed 9 months ago

purvi-ranawat commented 9 months ago

Bug Description :

While adding the internet archive server, if instead of entering the valid access key or click on acquire keys, if we enter random characters and click on Next, Internet Archive server is added. Instead it should give the error message stating to enter valid access key.

Steps to reproduce the behavior:

  1. Go to Save App.
  2. Click on Internet Archive to add Internet Archive server
  3. Enter random characters in Access keys fields and click on Next

Expected behavior : Error message should be display stating to enter valid Access Keys

Actual behaviour : No error message is displayed on entering the wrong access keys and internet archive server is added.

Below is the video :

https://github.com/OpenArchive/Save-app-ios/assets/8190141/eb4161b2-dbd6-4024-b747-0ab0f9b69931

Desktop (please complete the following information): OS: IOS 17.2 Device : Iphone XR

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

tladesignz commented 9 months ago

So, I just researched this again. Unfortunately, it is not possible to reliably test, if the keys are valid. Hence the iOS app did never try to.

The main problem is, that requests to the Internet Archive S3 root with valid credentials from new accounts look exactly the same as answers to invalid credentials.

This is related to https://github.com/OpenArchive/Save-app-android/issues/496.