search

OpenArchive / Save-app-ios

Secure Mobile Media Preservation
https://open-archive.org/
GNU General Public License v3.0
10 stars 3 forks source link

Friction with toggling Lock app off after disabling proofmode #271

Closed foundscapes closed 6 months ago

foundscapes commented 6 months ago

Describe the bug One should be able to toggle the "Lock App with Face ID or Device Passcode" after disabling Proofmode. Unfortunately one must close the app after disabling proofmode in order to turn off the Lock App feature. We not only need to fix this bug, but to create documentation/informational popup explaining how this works (and why).

To Reproduce Steps to reproduce the behavior:

  1. Go to Settings / General
  2. Click on ProofMode
  3. Deselect "Enable ProofMode" and deseclt "Secure ProofMode Key with Face ID or Device Passcode"
  4. Go back to General Settings and try to deselect Lock App with Face ID or Device Passcode - you can't.
  5. Close and reopen app, now you can deselect Lock App....

Expected behavior One should not have to close the app after disabling proofmode in order to turn off the Lock App feature, it should automatically become a functional button vs. grayed out.

Screenshots signal-2024-01-08-123455_003

Smartphone (please complete the following information):

Additional Notes We need to make sure this is working on Android

tladesignz commented 6 months ago

This was broken because the settings form was torn apart in two pieces during the redesign, and the dependency between "app-lock" and "secure-proofmode-key" was lost.

I fixed it and also added an explanatory text to when "app-lock" is unchangeable because a ProofMode key is secured.

This will be contained in build 96.

foundscapes commented 6 months ago

This is fixed in build 97 but there are spacing issues with the new language you added for clarity (ty for that!). Please fix and we can close! signal-2024-01-10-114724

tladesignz commented 6 months ago

%&!*...

Fix will be contained in build 98.

foundscapes commented 6 months ago

@tladesignz this is fixed, but now all the teal headings are cropped for both me and Lauren (iphone 12 minis) IMG_0664

tladesignz commented 6 months ago

Might be fixed in build 99.

purvi-ranawat commented 6 months ago

The header for each sections are cropped

Below is the screenshot :

Image

Environment Details : OS : IOS 17.2 Device : Iphone XR Build Version : 3.0.0, build 100

foundscapes commented 6 months ago

The teal headers are still cut off for me as well in build 100 IMG_0704

Environment Details : OS : IOS 17.1.2 Device : Iphone 12 mini Build Version : 3.0.0, build 100

tladesignz commented 6 months ago

sigh

Should be fixed in build 101.

purvi-ranawat commented 6 months ago

This is working fine.

Environment Details : OS : IOS 17.2 Device : Iphone XR Build Version : 3.0.0, build 101