OpenArchive / Save-app-ios

Secure Mobile Media Preservation
https://open-archive.org/
GNU General Public License v3.0
12 stars 3 forks source link

Code vs. Plain error language #276

Closed foundscapes closed 9 months ago

foundscapes commented 9 months ago

Describe the bug When upload doesn't work, we get incomprehensible error - this happened when connected/uploading to DropBox

To Reproduce Steps to reproduce the behavior:

  1. Add media
  2. Upload media
  3. See weird error

Expected behavior Errors should all be in plain language.

Screenshots IMG_1038

Smartphone (please complete the following information):

tladesignz commented 9 months ago

The important information here seems to have been the piece `insufficient_space´. I could reproduce that error by filling up my Dropbox to the brim.

I tried to improve the output of error messages from Dropbox. (See the commit link above for some crazy code I had to write to achieve this.)

I am not (and nobody else is), and never will be able to produce human-friendly error messages for all circumstances. There's tons of layers of code and systems that can produce all sorts of different errors in all sorts of crazy data structures.

The only thing we could do generally is to say "There was some error." That is human-readable, but it also contains zero information to what actually went wrong.

However, for many people, even a really ugly error message can help them fix their problem. Like in this case, those who bothered to try to spot some interesting information in there could come to the conclusion, that they maybe would need to clean up their Dropbox to continue working with it.

But I am happy to dissect any wild error you stumble across and make that nicer, as long as I am able to reproduce it.

Like in this case.

I think we discussed this already somewhere, but I can't find that issue now. Anyhow.

The fix will be contained in build 109.

tladesignz commented 9 months ago

@purvi-ranawat, you can test this error by filling up your Dropbox to the max!

purvi-ranawat commented 9 months ago

@tladesignz : This is working fine. I am getting only Insufficient_space message.

Below is the screenshot :

Image

Environment : OS : IOS 17.2 Device : Iphone XR Build Version : 3.2.1, build 109