Possible memory leak with XMP playback

OpenArena / engine

OpenArena modifications to the ioquake3 engine

http://openarena.ws

GNU General Public License v2.0

212 stars 50 forks source link

Possible memory leak with XMP playback #4

Open leilei- opened 8 years ago

leilei- commented 8 years ago

To reproduce:

get a nice big mod/s3m/it/xm file.
"music" it a bunch of times
watch a ncie crash happen.

This might have also been related to using an outdated (2014) libxmp while trying this though, Have not yet updated that to see if it's reproducable in it, but there's still the possibility it's OA's fault here

sago007 commented 7 years ago

While looking at S_XMP_CodecOpenStream I noticed that FS_ReadFile is called with an invalid buffer. This could likely be the cause of a crash (or something worse).