search

OpenAssetIO / OpenAssetIO-MediaCreation

OpenAssetIO extensions for use in the Media Creation industry.
Apache License 2.0
12 stars 10 forks source link

Share `traits.yml` via package data mechanism #16

Closed elliotcmorris closed 1 year ago

elliotcmorris commented 1 year ago

Came up from a comment

Rather than copying traits.yml in the generation-install manualy, we should have it copied over by adding it to a manifest.in file.

Add a test to verify that it's there.

elliotcmorris commented 1 year ago

Did some minor investigation around this issue, and it dosen't appear as straitforward as we'd hoped.

Investigations havn't been exhaustive, but doing the regular manifest approach we use elsewhere, (as well as some further experimentations, like attempting to move traits.yml inside the package directory so it can be considered package data more naturally,) failed to distribute traits.yml in the install.

It's doing this silently, so hard to know what's really happening, but I suspect this is the same issue of setuptools not really knowing about us as a proper package strait away, further suspect that if we added an __init.py__ into the empty directory things might magically start working, but am at the end of the timebox so am parking this for now.

foundrytom commented 1 year ago

Closing until there is a strong motivation to go down this habit hole.