Design: TraitGen to use new exceptions instead of `runtime_error` - Githubissues

OpenAssetIO / OpenAssetIO-TraitGen

A code generation tool that produces OpenAssetIO Traits and Specifications from a simple YAML description.

Apache License 2.0

5 stars 3 forks source link

Design: TraitGen to use new exceptions instead of `runtime_error` #50

Closed feltech closed 2 months ago

feltech commented 10 months ago

What

Use more appropriate and consistent exception strategy, making use of exception hierarchy migration/redesign in OpenAssetIO/OpenAssetIO#997.

This needs to be backwards compatible with a14

Why

In Python:

In get raise TypeError if an unexpected type is stored in the variant
In set raise TypeError if the wrong type is passed

In C++:

In get throw std::runtime_error if an unexpected type is stored in the variant
In set the type system prevents the wrong type being passed.

Should C++ and/or Python exceptions use the newly added exceptions? Do we need new ones?

I'd be tempted to punt all this, at least til after the beta.