Closed foundrytom closed 7 months ago
Installation via setuptools is currently broken. Remove setup.py and update pyproject.toml so we can still install with setuptools > 69.0.0.
setuptools
setup.py
pyproject.toml
69.0.0
Installing from PyPI currently misses dependencies as those listed in setup.py are no longer considered.
~According to https://github.com/pypa/setuptools/commit/3bd67c0e0f51da9823c074dc5645c3ab2284d16d we don't need to set include-package-data. However, consumers might be stuck on an older setuptools, so we should still include it.~ [edit: if you include it, setuptools errors, telling you not to].
include-package-data
What
Installation via
setuptools
is currently broken. Removesetup.py
and updatepyproject.toml
so we can still install withsetuptools
>69.0.0
.Why
Installing from PyPI currently misses dependencies as those listed in
setup.py
are no longer considered.Notes
~According to https://github.com/pypa/setuptools/commit/3bd67c0e0f51da9823c074dc5645c3ab2284d16d we don't need to set
include-package-data
. However, consumers might be stuck on an oldersetuptools
, so we should still include it.~ [edit: if you include it,setuptools
errors, telling you not to].