OpenAssetIO / OpenAssetIO

An open-source interoperability standard for tools and content management systems used in media production.
Apache License 2.0
282 stars 31 forks source link

[Lint] Pin linter versions #1250

Closed feltech closed 8 months ago

feltech commented 1 year ago

What

Following on from https://github.com/OpenAssetIO/OpenAssetIO-TraitGen/pull/12#discussion_r1133597508. Pin versions of linters used in CI checks. Document a process for regularly updating linter versions.

Why

Linters can have subtle changes over time that can make CI fail in ways unrelated to the work done in a given PR. This causes additional unplanned work to conform code as part of unrelated tasks.

Keeping up to date with the latest linter versions is hugely beneficial, however. We benefit from bugfixes in the linters themselves and new checks for vulnerabilities and support for more/newer language features.

So we should have a process for regularly reviewing our linter versions, bumping immediately if trivial and planning future work to conform to the new versions if non-trivial.

elliotcmorris commented 8 months ago

Closing due to low priority. Will tackle when it bites us.