search

OpenAssetIO / usdOpenAssetIOResolver

An AR2 plugin that hosts OpenAssetIO
Apache License 2.0
25 stars 3 forks source link

Update to use MediaCreation and general tidy #30

Closed foundrytom closed 1 year ago

foundrytom commented 1 year ago

Updates to use MediaCreation, along with general tidying to get this closer to a usable state.

This moves resolve back into resolve, as for the read case, we shouldn't need to bother the manager for the other entry points. As we have a separate write path, then we can do the trick of deferring till later there, without compromising the performance of the higher call-count read path.

I think we have write errors making sense now, but we should still look at ensuring critical errors in Resolve actually cause a real error. TF_FATAL_ERROR seems to be the way to go, but it rather aggressively SIGABRTs, unless otherwise handled. In Python we don't seem to be able to install a TfDiagnosticsMgr Delegate - resulting in forceful termination - which makes testing rather hard.

foundrytom commented 1 year ago

Added a pre-emptive commit to drop setting Context.retention here as it will soon be removed.