search

OpenAstroTech / OpenAstroTracker

3D printed DSLR tracking mount
Other
970 stars 124 forks source link

Indi Driver: Autocalculate HA from Date / Time and Longitude #132

Closed pmneo closed 3 years ago

pmneo commented 3 years ago

This will use Sideral to calculate HA when using the OAT with indilib.

This also provides some more data to the driver (Time Format 24h, Device Time and Date, and Dummy Site names) to avoid errors during Driver startup.

This also includes my fix for the wrong Latitude interpretation and extends the Info Menu by two more Pages (Driver Date and Driver UTC Time)

andre-stefanov commented 3 years ago

Please give us a feedback to the comments. Otherwise we will close it in context of the repository migration.

ClutchplateDude commented 3 years ago

@pmneo We will likely not accept this review as you keep adding things to it. You will need to make separate PRs for each feature, since this is not an acceptable way of merging new code into the repo. We need small chunks with one new feature in it, not a mega PR that keeps changing even though we've been reviewing it for weeks. You should address all the comments on it and make the requested changes instead of adding new features.

pmneo commented 3 years ago

@ClutchplateDude How to prevent GitHub to automatically add my commits to this pull request?

ClutchplateDude commented 3 years ago

@ClutchplateDude How to prevent GitHub to automatically add my commits to this pull request?

You use branches. From the command line, you do git checkout -b my-feature, if you're using a GUI client, there's probably a Create Branch command.... then you commit and push the features of that branch. To switch between branches you just uses teh same command without the -b.

andre-stefanov commented 3 years ago

@pmneo We will likely not accept this review as you keep adding things to it. You will need to make separate PRs for each feature, since this is not an acceptable way of merging new code into the repo. We need small chunks with one new feature in it, not a mega PR that keeps changing even though we've been reviewing it for weeks. You should address all the comments on it and make the requested changes instead of adding new features.

Unfortunately i have to agree on that. Your ideas are good, but it's really hard to keep overview of the changes. Please create separate branches based on the develop of the new repo. Each "feature branch" should contain only one feature/change. Then create a PR for each of them agains the develop. Otherwise it is not possible to get all the use cases and possible side effects tested properly.

andre-stefanov commented 3 years ago

Please create separate PRs as described in the comment above by following these rules.

pmneo commented 3 years ago

@andre-stefanov where is the code from develop branch gone?

andre-stefanov commented 3 years ago

@andre-stefanov where is the code from develop branch gone?

As stated in the comments above, the code is in the new repo.

pmneo commented 3 years ago

Oo ... how to create the pull requests from my old fork?

andre-stefanov commented 3 years ago

Oo ... how to create the pull requests from my old fork?

You will have to make a new fork and apply the changes there since the history there does not contain same hashes and can't be reused this way. The easiest way would be to fork, create feature branches and just copy your changes there. Then a pr as usual.