search

OpenAstronomy / azure-pipelines-templates

An opinionated set of Azure Pipelines templates for Python projects using pyproject.toml (PEP517) and tox
https://openastronomy-azure-pipelines.readthedocs.io/en/latest/
BSD 2-Clause "Simplified" License
11 stars 20 forks source link

Allow pulling git-lfs files in Azure CI #40

Closed StanczakDominik closed 4 years ago

StanczakDominik commented 4 years ago

We ran into the issue of Azure not pulling git-lfs files during https://github.com/PlasmaPy/PlasmaPy-NEI/pull/21

As it turns out, adding lfs: true to the checkout step as in this change:

https://github.com/PlasmaPy/PlasmaPy-NEI/pull/21/commits/d3360c3cba0fe95e949ec7d0cc35495c7929e8c1

allows Azure to easily grab them.

This change was guided by Azure docs over at https://docs.microsoft.com/en-us/azure/devops/pipelines/repos/pipeline-options-for-git?view=azure-devops#checkout-files-from-lfs

I didn't see any easy way of overriding this setting downstream, and I currently see no disadvantages to putting it in upstream.

Cadair commented 4 years ago

I assume this doesn't cause any issues for repos not using lfs?

StanczakDominik commented 4 years ago

I expect so - I wouldn't see it breaking anything if LFS isn't used.

Cadair commented 4 years ago

let's find out :grinning: