search

OpenAstronomy / azure-pipelines-templates

An opinionated set of Azure Pipelines templates for Python projects using pyproject.toml (PEP517) and tox
https://openastronomy-azure-pipelines.readthedocs.io/en/latest/
BSD 2-Clause "Simplified" License
11 stars 20 forks source link

Update to use python-build CLI over pep517 #50

Closed Cadair closed 4 years ago

Cadair commented 4 years ago

It appears that pep517 want to remove the frontend (CLI) and be a pure library, so build is basically the CLI it depends on pep517 for the magic.

pllim commented 4 years ago

Do you happen to know if this can be done in other Python versions too?

Cadair commented 4 years ago

What do you mean by other python versions?

pllim commented 4 years ago

Are you running this in all Python 3.6-3.8 or just 3.7? My azure-fu isn't that strong.

Cadair commented 4 years ago

The python version which builds the wheels is controlled by cibuildwheel the section of code modified here is version agnostic. The universal wheels and the sdists should be the same irrespective of what version of python you build them with :smile:.

Is that an answer to your question?!

Cadair commented 4 years ago

I see now we are actually specifying a version for the builds, I might remove that, and just default to what azure gives us, as it shouldn't matter.

pllim commented 4 years ago

Okay, I think that answers it. Thanks!

pllim commented 4 years ago

Not sure how you got it to work. I get an error:

/opt/hostedtoolcache/Python/3.8.5/x64/bin/python: No module named build

https://dev.azure.com/spacetelescope/acstools/_build/results?buildId=3757&view=logs&j=b25f120e-e38e-5d50-120e-fa71f5e29986&t=b1d60ffd-f6c2-56b4-1446-ab1e65159582&l=75