search

OpenAstronomy / baldrick

I have a cunning plan!
https://baldrick.readthedocs.io
MIT License
14 stars 8 forks source link

Fix stale PR script #74

Closed astrofrog closed 5 years ago

astrofrog commented 5 years ago

The stale PR script still used a configuration item in one place, but we shouldn't do this since the config infrastructure relies on current_app which only works inside the flask context.

Since the stale scripts are opt in anyway, as they require a cron job to be set up, and since we already removed all the other config related to the time to warn and time to close, I think this was just an oversight.

codecov-io commented 5 years ago

Codecov Report

Merging #74 into master will decrease coverage by 0.06%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #74      +/-   ##
==========================================
- Coverage   82.79%   82.72%   -0.07%     
==========================================
  Files          16       16              
  Lines         802      799       -3     
==========================================
- Hits          664      661       -3     
  Misses        138      138
Impacted Files Coverage Δ
baldrick/scripts/stale_pull_requests.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e8f5be8...8458ae8. Read the comment docs.