Cadair commented 4 years ago

This just posts a comment on all PRs only on open events. It might be nice to be able to limit this to new contributors, or exclude people who are in teams in the org or something. However, for now this should suffice.

Based on #87 and needs docs.

codecov-io commented 4 years ago

Codecov Report

Merging #94 into master will decrease coverage by 0.94%. The diff coverage is 21.42%.

@@            Coverage Diff            @@
##           master     #94      +/-   ##
=========================================
- Coverage   82.34%   81.4%   -0.95%     
=========================================
  Files          17      18       +1     
  Lines         912     925      +13     
=========================================
+ Hits          751     753       +2     
- Misses        161     172      +11

Impacted Files	Coverage Δ
baldrick/plugins/github_welcome.py	`0% <0%> (ø)`
baldrick/plugins/github_towncrier_changelog.py	`79.76% <100%> (+0.24%)`	:arrow_up:
baldrick/plugins/github_milestones.py	`100% <100%> (ø)`	:arrow_up:
baldrick/plugins/github_pull_requests.py	`83.51% <100%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 116546d...c3247fc. Read the comment docs.

Cadair commented 4 years ago

I think there is actually a better way to achieve this, without the breaking change. However, I do wonder if passing the full webhook payload through is still a good idea.

pllim commented 3 years ago

Maaaaaybe this should be GitHub Action...

OpenAstronomy / baldrick

A new plugin to post a welcome comment #94

Codecov Report