search

OpenAstronomy / build-python-dist

GitHub action to build a source distribution for a Python package, and optionally a wheel for pure-Python packages.
MIT License
2 stars 5 forks source link

Add option for pipx instead of pip #19

Open nstarman opened 10 months ago

nstarman commented 10 months ago

Probably low priority, but would be nice if there were an option for pipx instead of pip.

https://github.com/OpenAstronomy/build-python-dist/blob/44d5b0da2b8733abddc7ecff7afbdbd6630dd171/action.yml#L41

Cadair commented 9 months ago

What would the advantage of that be in an isolated environment like this?

nstarman commented 9 months ago

Compatability with the framework being developed in https://github.com/scientific-python/cookie for testing.

Cadair commented 9 months ago

Can you explain that a bit more? It feels unhelpful to layer more venv tools ontop of an already isolated env, but I don't know much about this

nstarman commented 9 months ago

At Astropy we've stopped supporting our own package template in favor of the scientific-python package guide. They have developed https://github.com/scientific-python/cookie. It would be great to increase compatibility with their work, since we officially endorse it. I would be happy however that happens, so I opened this PR to start requesting support for some differences I noticed between our testing frameworks (another is nox versus tox).

https://github.com/scientific-python/cookie/blob/main/%7B%7Bcookiecutter.project_name%7D%7D/.github/workflows/ci.yml

astrofrog commented 9 months ago

So do you mean we would run tox/nox using pipx rather than pip install tox and run it separately?