search

OpenAstronomy / conda-channel

An open source community conda channel
8 stars 8 forks source link

Fixing version incompatibilities and updates to package versions #28

Closed bsipocz closed 7 years ago

bsipocz commented 7 years ago

I'm moving in changes from conda-channel-astropy where we already fixed the conda/conda-build version issues that probably the cause of the failures in #27 and #26.

The PR also updates the versions for various packages (mpdaf, contextlib2, glymur).

bsipocz commented 7 years ago

This should be good to go in, the failures are due to mpdaf not being compatible with astropy 1.3

saimn commented 7 years ago

@bsipocz - Thanks for taking care of this ! Mpdaf 2.1 is indeed not compatible with Astropy 1.3 (due to the removal of astropy.visualization.zscale), and that's why we released version 2.2. I wanted to update the recipe after #26 to make sure that it is built with the correct cfitsio version (i.e. the one that is installed later as a dependency). So maybe after #26 is merged a rebuild of Mpdaf will be necessary.

bsipocz commented 7 years ago

In that case I think it's the cleanest that I cherry-pick your cfitsio update commits here (as this branch seem to pass and successfully builds.) Or we merge that one first, getting a failing build, but the merge this straight after.

Pinging @Cadair and @mwcraig as I guess they have commit rights here.

saimn commented 7 years ago

I think you can merge this one first, as it should build fine with the current cfitsio version. Then once the new cfitsio version is merged, we can rebuild Mpdaf with it.

saimn commented 7 years ago

Oh wait, the current build actually uses cfitsio 3.41 from conda-forge ! It was added there recently: https://github.com/conda-forge/cfitsio-feedstock However their recipe is missing the --enable-reentrant flag. I will report this.

bsipocz commented 7 years ago

@saimn - I don't have merge rights, so we need to wait for one of the maintainers to do that.

saimn commented 7 years ago

@bsipocz - Ok, no problem ;)

mwcraig commented 7 years ago

Merging... @bsipocz -- do you want to be added as a maintainer on this repo?

bsipocz commented 7 years ago

@mwcraig - I can't do much development beyond copying over what you do in conda-channel-astropy but can merge trivial PRs like the ones opened recently. So if you think it's helpful then it's fine by me.