Remove cfitsio as it is now in conda-forge - Githubissues

OpenAstronomy / conda-channel

An open source community conda channel

8 stars 8 forks source link

Remove cfitsio as it is now in conda-forge #29

Closed saimn closed 7 years ago

saimn commented 7 years ago

@mwcraig - Is there a way to copy cfitsio from conda-forge, to make it available from the OpenAstronomy channel ?

bsipocz commented 7 years ago

@saimn - I believe that the machinery is the same as in conda-channel-astropy, so if something is in conda-forge we copy it over.

saimn commented 7 years ago

@bsipocz - But how is determined what must be copied ? You mean if there is an entry in requirements.yml ?

bsipocz commented 7 years ago

yes, there should be an entry in requirements, and if it's exists in conda-forge, it gets copied over. I'm not sure what happens if there is a recipe template as well (I assume the copying is higher priority), @mwcraig knows the details.

mwcraig commented 7 years ago

Recipes are created in this priority order:

If a recipe template is present, it is used.
If there is no recipe template and the package is on conda-forge, the recipe is is copied from conda-forge.
Otherwise, a recipe is generated with conda skeleton.

The entire infrastructure really needs a re-write so that building is done on conda-forge and these "subset" channels use something like requirements.yml to mirror those packages. One of these weekends...

saimn commented 7 years ago

Thanks for the explanations @mwcraig , I added cfitsio to the requirements.yml so it should now be copied from conda-forge.

mwcraig commented 7 years ago

Just pushed a change that should make the lights green (updating sunpy version)

mwcraig commented 7 years ago

I'm going to have to try doing a real fix for copying from conda-forge; it is failing because right now I just copy the recipe file. The build fails here because there is a patch in the conda-forge repo that isn't being copied. This weekend, I hope...

mwcraig commented 7 years ago

Hopefully this builds...

@bsipocz -- if this works and is merged then there will be no need to list version numbers for packages on conda-forge. This will simply pull in whatever the conda-forge version is at the time the builder is run.

bsipocz commented 7 years ago

@mwcraig - Sounds great.

mwcraig commented 7 years ago

close/reopen to retrigger builds...

mwcraig commented 7 years ago

I'll add a restriction on the numpy version tomorrow to exclude numpy 1.12 and then linux/mac should work.

Hopefully windows will be an easy fix, will have time to boot up a vm on Monday.

mwcraig commented 7 years ago

Thanks, @bsipocz -- I've ended up cutting out builds to try to get this to pass (think it is there now). Really need to write a script to just copy from one channel to another tomorrow...

mwcraig commented 7 years ago

Merging before something breaks... 😬

saimn commented 7 years ago

Thanks @mwcraig !