search

OpenAstronomy / github-actions-workflows

Reusable workflows for GitHub Actions
https://github-actions-workflows.openastronomy.org
MIT License
20 stars 13 forks source link

Revert splitting out of coverage step #206

Closed astrofrog closed 5 months ago

astrofrog commented 5 months ago

This reverts https://github.com/OpenAstronomy/github-actions-workflows/pull/199 as it is causing CI to fail in e.g. glue and reproject and other projects. We should make sure we test any follow-up repeat PR more extensively to make sure there are no more issues.

pllim commented 5 months ago

Should have at least kept the fail_ci_if_error: true but I don't feel like opening PR here anymore for this issue as I have other things to take care of for now.

astrofrog commented 5 months ago

Sorry I just did a plain revert as I was in a rush to fix things, will see if I can add that back later.

pllim commented 5 months ago

Might take longer than you expect... I got inexplicable token error over at https://github.com/astropy/astropy/issues/16535

Maybe not worth it and should spend the energy to get rid of codecov altogether... See https://github.com/OpenAstronomy/github-actions-workflows/issues/189