search

OpenAstronomy / github-actions-workflows

Reusable workflows for GitHub Actions
https://github-actions-workflows.openastronomy.org
MIT License
18 stars 14 forks source link

binary upload job is uploading all artefacts regardless if that run created them. #215

Open nabobalis opened 2 months ago

nabobalis commented 2 months ago

We have two action runs to compile wheels, one for a range of platforms and one for aarch64.

If you see https://github.com/sunpy/sunpy/actions/runs/9915099064 for an example.

The upload step for the non-aarch64 run also tries to upload the aarch64 wheel which feels like it shouldn't be doing?

Is this expected behaviour?

ConorMacBride commented 2 months ago

Hi @nabobalis! The upload section for both publish jobs currently downloads all build artifacts for the ci.yml workflow run matching dist-*, which is why you are seeing the wrong wheels. So it looks like we need to update publish.yml to use more unique build artifact names; ones that include the job name used within the caller workflow e.g. publish_exotic. I'm not sure how we access that name within the reusable workflow but it should be somewhere.