OpenAstronomy / github-actions-workflows

Reusable workflows for GitHub Actions
https://github-actions-workflows.openastronomy.org
MIT License
20 stars 13 forks source link

MNT: Use hash for Action workflow versions and update if needed #234

Closed pllim closed 2 days ago

pllim commented 2 months ago

As recommended by https://scientific-python.org/specs/spec-0008/#pin-github-actions-release-workflows-to-their-full-release-commit-shas , this PR changes your Actions workflow version pins to hashes, and updates to latest release hashes (at the time of writing) if needed.

This is an automated update made by the batchpr tool :robot: - feel free to close if it doesn't look good! You can report issues to @pllim.

:ghost:

Cadair commented 2 months ago

@pllim do we need to do anything to configure dependabot to handle this format?

pllim commented 1 month ago

No, I don't think so. @bsipocz can confirm if you need second opinion. Thanks!

bsipocz commented 1 month ago

Yeap, no changes are needed for dependabot, it handles the hashes well. (Though my preference is to have a grouped, monthly run)

pllim commented 1 month ago

grouped, monthly run

If Stuart wants that, I can also attach that change in this PR real quick. Just lemme know.

Cadair commented 1 month ago

Go for it!

pllim commented 1 month ago

Done. Thanks, all!

Cadair commented 2 days ago

@pllim can you rebase this?

pllim commented 2 days ago

@Cadair I used the GitHub web interface to resolve conflicts which introduced merge commit. Please squash and merge. Thanks!

pllim commented 2 days ago

There are some runner errors/warnings that are not related to this PR?

https://github.com/OpenAstronomy/github-actions-workflows/actions/runs/12015369295

bsipocz commented 2 days ago

Thanks @pllim!