Closed Cadair closed 11 months ago
Some beautiful changes, you should thank the person who started the ball on this.
👍
Do we want setuptools_scm to be optional (it isn't at the moment).
not having it would mean that we can have a reasonable dev version number without the awkward tagging after a release, right? If yes, then also I would go with "no" for q2
without the awkward tagging after a release
Well that's a "feature" of tagging on release branches. I think that minor annoyance is worth the general helpfulness of not having to manually maintain a version number.
I would point out at this point that this is supposed to be an opinionated template & guide, everything in the template should be documented and we want the documentation to be easy to follow.
The only middle ground we could do is have a hidden option which defaults to on, so downstream templates could optionally turn it off, although I would rather not do that either. If it's worth having then it's worth having on by default and documenting.
Well, opinions differ then what is convenient, while this workflow can work for large libraries, I would not want to do this dev tagging for a frequently released package where releases are done from the default branch. (and dev tagging is basically just as manual than any other way to bump the version number)
where releases are done from the default branch
You don't have to do it in this case, you only have to dev tag if you put your release tags on the not default branch.
Well I am close. The tests pass locally for me but here I get some insane virtualenv error :sob:
This is a continuation of #13 with some further cleanup.
Fixes #1 by docs Fixes #19
Questions to answer before merge: