OpenAtomFoundation / pika

Pika is a Redis-Compatible database developed by Qihoo's infrastructure team.
BSD 3-Clause "New" or "Revised" License
5.84k stars 1.19k forks source link

merge submodule and update rocksdb using cmake #1211

Closed kernelai closed 1 year ago

kernelai commented 1 year ago

goal:

env: ubuntu 22.04.1 LTS g++ version: g++ 11.3.0 rocksdb version : v7.7.3

kernelai commented 1 year ago

when merge blackwidow , found error [build] /home/kernelai/github.com/pika/src/blackwidow/src/db_checkpoint.cc:21:10: fatal error: util/file_util.h: No such file or directory [build] 21 | #include "util/file_util.h" [build] | ^~~~~~~~~~~~~~~~~~ [build] compilation terminated.

kernelai commented 1 year ago

when merge blackwidow , found error [build] /home/kernelai/github.com/pika/src/blackwidow/src/db_checkpoint.cc:21:10: fatal error: util/file_util.h: No such file or directory [build] 21 | #include "util/file_util.h" [build] | ^~~~~~~~~~~~~~~~~~ [build] compilation terminated.

modify

#include util/file_util.h
#include util/filename.h

to

#include "file/file_util.h"
#include "file/filename.h"
kernelai commented 1 year ago

error:

In file included from /home/kernelai/github.com/pika/src/blackwidow/src/blackwidow.cc:9:
[build] /home/kernelai/github.com/pika/src/blackwidow/src/options_helper.h:47:1: error: could not convert ‘{{"max_background_jobs", {208, blackwidow::MemberType::kInt}}, {"max_background_compactions", {212, blackwidow::MemberType::kInt}}, {"base_background_compactions", {<expression error>, blackwidow::MemberType::kInt}}, {"max_open_files", {68, blackwidow::MemberType::kInt}}, {"bytes_per_sync", {400, blackwidow::MemberType::kUint64T}}, {"delayed_write_rate", {456, blackwidow::MemberType::kUint64T}}, {"max_total_wal_size", {80, blackwidow::MemberType::kUint64T}}, {"wal_bytes_per_sync", {408, blackwidow::MemberType::kUint64T}}, {"stats_dump_period_sec", {304, blackwidow::MemberType::kUint}}}’ from ‘<brace-enclosed initializer list>’ to ‘std::unordered_map<std::__cxx11::basic_string<char>, blackwidow::MemberTypeInfo>’
[build]    47 | };
[build]       | ^
[build]       | |
[build]       | <brace-enclosed initializer list>

base_background_compactions has been removed link

kernelai commented 1 year ago

errror:

build] /home/kernelai/github.com/pika/src/blackwidow/../../third/rocksdb/util/core_local.h:66:15: error: ‘port’ has not been declared
[build]    66 |   int cpuid = port::PhysicalCoreID();

this is because bw/db_checkpoint.cc use CopyFile function which in rocksdb/file/file_util.cc。it cant find name port which is configed posix version. so, add add_definitions(-DROCKSDB_PLATFORM_POSIX -DROCKSDB_LIB_IO_POSIX)in bw cmakelist