fix: duplicate meta key read

[wangshao1]

fix bugs mentioned in https://github.com/OpenAtomFoundation/pika/issues/2735

Summary by CodeRabbit

• New Features

  • Added support for prefetching metadata in various Redis operations, enhancing performance and efficiency.

• Refactor

  • Updated Redis methods across different data structures (Strings, Hashes, Lists, Sets, Zsets, Streams) to accept a prefetch_meta parameter, optimizing metadata handling.
  • Improved logic in key existence checks and expiration handling.

• Bug Fixes

  • Ensured consistency with Redis implementation by setting exists = true and returning Status::OK() in specific conditions.

• Performance Improvements

  • Enhanced the flow of operations by incorporating prefetch metadata, leading to more efficient handling of Redis commands.

[coderabbitai[bot]]

Walkthrough

The changes introduce a std::string&& prefetch_meta parameter to several methods in the Redis class across different data structure modules. This enhancement aims to improve efficiency in handling meta information related to expiration, deletion, persistence, and time-to-live operations, adding consistency and optimization across various Redis data types like Strings, Hashes, Lists, Sets, Zsets, and Streams.

Changes

File Path	Change Summary
src/storage/src/redis.h	Added std::string&& prefetch_meta parameter to multiple Redis class methods for expiration, deletion, persistence, TTL, and cardinality operations.
src/storage/src/redis_hashes.cc	Updated Redis class methods for Hashes to include std::string&& prefetch_meta parameter for handling meta information.
src/storage/src/redis_lists.cc	Added std::string&& prefetch_meta parameter to Redis class methods for Lists, affecting expiration, deletion, persistence, and TTL operations.
src/storage/src/redis_sets.cc	Updated Redis class methods for Sets to accept an additional std::string&& prefetch_meta parameter for enhanced meta handling.
src/storage/src/redis_streams.cc	Modified Redis class methods for Streams to include std::string&& prefetch_meta for stream processing and metadata handling.
src/storage/src/redis_strings.cc	Refactored Redis class methods for Strings to accept std::string&& prefetch_meta parameter; improved consistency and meta value handling.
src/storage/src/redis_zsets.cc	Enhanced Zset-related methods in the Redis class by adding std::string&& prefetch_meta; reorganized variable declarations and initialization.
src/storage/src/storage.cc	Updated Storage::MSetnx logic to directly check for key existence using the IsExist method rather than retrieving and checking the value.

Poem

🐇

In the land of Redis, with keys held tight, Meta flows swift with newfound might.
Prefetch dreams and TTL gleams,
Through Hashes, Lists, and Streams.
Efficiency whispers, a silent delight,
In “storage” we code, from morning till night.
The rabbit cheers with coding spree, For optimizations set us free! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.