feat:Statistics ticker count

baixin01 commented 3 months ago

1.配置中增加 open_rocksdb_statistics_tickers ，默认为no。开启会损耗+1.5% 2.info rocksdb统计 statistics统计

Summary by CodeRabbit

New Features
- Introduced new configuration options to enable or disable database statistics and set their detail level.
Improvements
- Enhanced the retrieval of RocksDB information to optionally include detailed statistics based on user-defined settings.
Bug Fixes
- Implemented safeguards to ensure the statistics level cannot be set below zero.

coderabbitai[bot] commented 3 months ago

Walkthrough

These changes enhance the pika.conf configuration by introducing parameters for managing database statistics, specifically enable-db-statistics and db-statistics-level. This allows users to toggle statistics logging and specify the detail level. Various components have been updated to ensure that RocksDB statistics can be easily managed, improving overall functionality and user control.

Changes

Files	Change Summary
`conf/pika.conf`	Introduced `enable-db-statistics`, `db-statistics-level`, and modified `open_rocksdb_statistics_tickers`.
`include/pika_conf.h`	Added methods `enable_db_statistics()` and `db_statistics_level()` with corresponding member variables.
`src/pika_admin.cc`, `src/storage/src/redis.cc`, `src/storage/src/storage.cc`	Updated `GetRocksDBInfo` method to include a new parameter for conditional statistics logging.
`src/pika_conf.cc`	Enhanced `Load` and `ConfigRewrite` methods to manage new statistics configurations.
`src/storage/include/storage/storage.h`	Updated `GetRocksDBInfo` signature to accept the new `open_ticker` parameter.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Pika
    participant Config
    participant RocksDB
    participant Redis

    User->>+Pika: Update pika.conf (enable-db-statistics)
    Pika->>+Config: Load configuration
    Config->>Config: Set enable_db_statistics_
    Config-->>-Pika: Configuration loaded

    User->>+Pika: Request RocksDB Info
    Pika->>+Config: Check enable_db_statistics()
    Config-->>-Pika: Return boolean value
    Pika->>+Redis: Call GetRocksDBInfo with boolean parameter
    Redis->>RocksDB: Fetch info with or without ticker based on parameter
    RocksDB-->>Redis: Return info details
    Redis-->>Pika: Return formatted info
    Pika-->>User: Display RocksDB Info

Poem

In the forest of code, new choices bloom,
Statistics dancing, dispelling the gloom.
Tickers can flutter, or rest for a while,
With Pika's new options, we manage in style.
Configuration’s magic, now clearer than night,
Enhancing our tools, making features shine bright! 🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

baixin01 commented 3 months ago

@coderabbitai review @CodiumAI-Agent /review @CodiumAI-Agent /improve

coderabbitai[bot] commented 3 months ago

@baixin01: I will review the changes and provide feedback.

Actions performed

Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

baixin01 commented 3 months ago

@coderabbitai review

coderabbitai[bot] commented 3 months ago

Actions performed

Review triggered. > Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

baixin01 commented 3 months ago

@CodiumAI-Agent /review

baixin01 commented 3 months ago

@CodiumAI-Agent /improve

CodiumAI-Agent commented 3 months ago

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 4 🔵🔵🔵🔵⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review

**Configuration Consistency:** Ensure that the configuration option "open-rocksdb-statistics-tickers" is consistently handled across all relevant files and methods. It appears to be well integrated, but thorough testing is needed to confirm that it behaves as expected under different scenarios. **Performance Impact:** The addition of detailed ticker statistics can have a performance impact, as noted in the PR description. It's important to ensure that this feature can be toggled without side effects and does not degrade performance when disabled. **Error Handling:** The error message for invalid argument in "ConfigSet" method should be tested to ensure it provides clear feedback to the user.

OpenAtomFoundation / pika