fix: PkPatternMatchDel inconsistent between rediscache and db

haiyang426 commented 3 days ago

issue: #2715

Summary by CodeRabbit

New Features
- Introduced enhanced pattern matching deletion functionality with key removal capability.
Improvements
- Enhanced database operations handling during pattern match deletions.
- Improved cache update mechanisms following deletion operations.

coderabbitai[bot] commented 3 days ago

Walkthrough

The changes introduce a method for pattern-matching deletions that also tracks removed keys, revamped the PKPatternMatchDelCmd class to leverage this new method, and added corresponding database and cache update procedures. Additionally, the Storage and Redis classes now include new functionalities to support this feature.

Changes

Files/Groups	Change Summary
`include/pika_admin.h`	Added new method declarations (`DoThroughDB()`, `DoUpdateCache()`) and a data member `remove_keys_` in `PKPatternMatchDelCmd`.
`src/pika_admin.cc`	Updated `Do()` method in `PKPatternMatchDelCmd` to use `PKPatternMatchDelWithRemoveKeys` and handle results, added new methods for database operations and cache updates.
`src/storage/include/storage/storage.h`, `src/storage/src/storage.cc`	Added `PKPatternMatchDelWithRemoveKeys` method with key removal capability.
`src/storage/src/redis.h`, `src/storage/src/redis_strings.cc`	Added function `PKPatternMatchDelWithRemoveKeys` to perform pattern-matching deletions along with key removal.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant PKPatternMatchDelCmd
    participant Storage
    participant Redis

    User ->> PKPatternMatchDelCmd: Do()
    PKPatternMatchDelCmd ->> Storage: PKPatternMatchDelWithRemoveKeys()
    Storage ->> Redis: PKPatternMatchDelWithRemoveKeys()
    Redis -->> Storage: List of removed keys
    Storage -->> PKPatternMatchDelCmd: List of removed keys
    PKPatternMatchDelCmd ->> PKPatternMatchDelCmd: DoThroughDB()
    PKPatternMatchDelCmd ->> PKPatternMatchDelCmd: DoUpdateCache()
    PKPatternMatchDelCmd -->> User: Operation Result

Poem

In code we dance, in bytes we play,
Patterns matched, keys fall away.
Through the database we swiftly glide,
In cache, we now confide.
With each line, we streamline flow,
A rabbit's joy, to watch it grow! 🌟

[!TIP]

AI model upgrade
## `gpt-4o` model for reviews and chat is now live OpenAI claims that this model is better at understanding and generating code than the previous models. Please join our [Discord Community](https://discord.com/invite/GsXnASn26c) to provide any feedback or to report any issues.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

wangshao1 commented 9 hours ago

另外还有一个问题，如果磁盘数据量比较大且匹配到的key比较多，内存占用比较多（记录了remove_key），处理耗时比较长。这个命令是pika自己的，所以是否需要定义一个每次操作可以删除的最大个数。

Issues-translate-bot commented 9 hours ago

Bot detected the issue body's language is not English, translate it automatically.

There is another problem. If the amount of disk data is relatively large and there are many matched keys, the memory usage will be large (remove_key is recorded), and the processing will take a long time. This command is pika's own, so do you need to define a maximum number that can be deleted in each operation?

haiyang426 commented 8 hours ago

另外还有一个问题，如果磁盘数据量比较大且匹配到的key比较多，内存占用比较多（记录了remove_key），处理耗时比较长。这个命令是pika自己的，所以是否需要定义一个每次操作可以删除的最大个数。

感谢，我尝试改一下

Issues-translate-bot commented 8 hours ago

Bot detected the issue body's language is not English, translate it automatically.

There is another problem. If the amount of disk data is relatively large and there are many matched keys, the memory usage will be relatively large (remove_key is recorded), and the processing will take a long time. This command is pika's own, so do you need to define a maximum number that can be deleted in each operation?

Thanks, I'll try to change it

OpenAtomFoundation / pika