using rocky linux instead of centos in github ci workflow - Githubissues

OpenAtomFoundation / pika

Pika is a Redis-Compatible database developed by Qihoo's infrastructure team.

BSD 3-Clause "New" or "Revised" License

5.83k stars 1.19k forks source link

using rocky linux instead of centos in github ci workflow #2806

Closed AlexStocks closed 1 month ago

AlexStocks commented 1 month ago

Is this a regression?

Yes

Description

github ci workflow always failed on centos platform.

somebody suggests we use centos stream or rocky linux instead.

Considering the steady of OS, we should use rocky linux as our platform instead of centos.

Please provide a link to a minimal reproduction of the bug

No response

Screenshots or videos

No response

Please provide the version you discovered this bug in (check about page for version information)

No response

Anything else?

No response

lqxhub commented 1 month ago

https://github.com/OpenAtomFoundation/pika/blob/6c0e0d42d153c98f7b27641d6f891815a382efaf/CMakeLists.txt#L162-L170

cmake 中很多和 centos 相关的判断, 这个应该需要同步修改