OpenAtomFoundation / pikiwidb

a high-performance, large-capacity, multi-tenant, data-persistent, strong data consistency based on raft, Redis-compatible elastic KV data storage system based on RocksDB

BSD 3-Clause "New" or "Revised" License

194 stars 63 forks source link

feat: add rename and renamenx #299

Closed zztaki closed 3 months ago

zztaki commented 4 months ago

30

This PR aims to add rename and renamenx commands for pikiwidb.

Running ./pikiwidbtests.sh basic

There are a few places that I think need to be focused on.

dingxiaoshuai123 commented 4 months ago

May I ask if it is possible to supplement some Go tests to validate the functionality of this command?

zztaki commented 4 months ago

May I ask if it is possible to supplement some Go tests to validate the functionality of this command?

I haven't implemented it yet. Are there any good examples? :)

dingxiaoshuai123 commented 4 months ago

May I ask if it is possible to supplement some Go tests to validate the functionality of this command?

I haven't implemented it yet. Are there any good examples? :)

May I ask if it is possible to supplement some Go tests to validate the functionality of this command?

I haven't implemented it yet. Are there any good examples? :)

There are Go test files under the path pikiwidb/tests, which can be referred to for inspiration.

dingxiaoshuai123 commented 4 months ago

May I ask if it is possible to supplement some Go tests to validate the functionality of this command?

I haven't implemented it yet. Are there any good examples? :)

https://github.com/redis/go-redis/blob/master/commands_test.go This might be helpful to you.

zztaki commented 4 months ago

May I ask if it is possible to supplement some Go tests to validate the functionality of this command?

I haven't implemented it yet. Are there any good examples? :)

https://github.com/redis/go-redis/blob/master/commands_test.go This might be helpful to you.

Thank you for your help! I will complete it at night.

zztaki commented 3 months ago

cicheck

zztaki commented 3 months ago

Current PR is blocked by this error.

Issues-translate-bot commented 3 months ago

Bot detected the issue body's language is not English, translate it automatically.

dingxiaoshuai123 commented 3 months ago

Current PR is blocked by this error.

Please update the code.

zztaki commented 3 months ago

Current PR is blocked by this error.

Please update the code.

Done